Hide annoying error print outs. #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
test/cli.js
Outdated
Contributor
There was a problem hiding this comment.
I'd use Test worker exited with ...
Contributor
Author
|
I just realized I could use |
jamestalmage
force-pushed
the
hide-annoying-error-printouts
branch
from
f21a99a to
d7adff4
Compare
test/cli.js
Outdated
jamestalmage
force-pushed
the
hide-annoying-error-printouts
branch
from
d7adff4 to
6033e9c
Compare
Contributor
Author
|
OK, updated to use |
sindresorhus
added a commit
that referenced
this pull request
Dec 29, 2015
Hide annoying error print outs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339.
To get the correct file and line number from
SyntexErrors, we need to give up control of how they are logged to console (see #308 for a full discussion on why this is true).The unfortunate side effect was that tests exercising our syntax errors
I was not sure this was worth it (it is a lot of code two fix the output from just two tests), but then I stumbled on this. There seem to be situations where a bad plan count, will not fail the tap test suite. Now I think this is probably worth the effort.